feat: push notifications #11652
feat: push notifications #11652
Conversation
- feat(push): relay events for push notifications registration and errors to app - feat(push): gate apns by `push-notifications` feature Relates-To: tauri-apps#11651 Signed-off-by: Sam Gammon <[email protected]>
Signed-off-by: Sam Gammon <[email protected]>
Signed-off-by: Sam Gammon <[email protected]>
Signed-off-by: Sam Gammon <[email protected]>
Signed-off-by: Sam Gammon <[email protected]>
Signed-off-by: Sam Gammon <[email protected]>
Signed-off-by: Sam Gammon <[email protected]>
Signed-off-by: Sam Gammon <[email protected]>
Signed-off-by: Sam Gammon <[email protected]>
|
Any way I can help ship this? |
|
@ChrisCates Very close to completion, i'm testing on macOS shortly. I haven't explored Android yet, so some research there might help (how best to integrate Firebase Cloud Messaging - FCM - into Windows is looking solid but I'm not sure how to extract the token yet. That may remain experimental until later if only because I can't find any third party push services that support WNS at this time. tl;dr I'd say we could get macOS and potentially iOS working within a few days. Android and WNS are probably easier/less complex, but may take a few days longer for research about how best to integrate. Regarding review and merge, I've no clue, this is my first PR to Tauri. |
Relates-To: tauri-apps/tauri#11652 Relates-To: tauri-apps/tauri#11651 Signed-off-by: Sam Gammon <[email protected]>
|
this needs a rebase but otherwise it is close to being done. there also need to be methods to trigger a request for notification permissions, which is required on platforms like iOS and Android. windows notification service ("WNS") will probably remain experimental for now |
Package Changes Through d368d87There are 7 changes which include tauri-bundler with minor, tauri-cli with minor, @tauri-apps/cli with minor, tauri with minor, tauri-runtime with minor, tauri-runtime-wry with minor, tauri-utils with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
|
cc / @amrbashir Could somebody on the Tauri team rendezvous with me on Discord (I'm in the contributors channel), or perhaps offer some guidance about whether this PR could be welcome? |
|
I don't think there are any objections around the added functionality, it is just this PR is marked as draft so the team probably thought it is not finished yet. That said, it looks good from my perspective but since this PR is more specific to macOS/iOS, I'd better let @lucasfernog or @FabianLars review and approve Also feel free to ping with us in the Discord contributors channel if you need to dicuss something |
|
Understood @amrbashir and thank you for getting back so quickly. It's marked as a draft because it will involve changes to (at least) I guess I'm worried that this is invasive enough that it may be a non-starter. I'm glad to see a positive nod. I can rebase this and get it as clean as possible, avoiding speculative changes, and then mark for review (Still, any preliminary feedback is welcome) |
|
Don't worry about how many crates you need to change, it is something we do often. |
Summary
Adds initial support wiring for Push Notifications (see: #11651).
This requires instrumentation down into
tao, to call methods on theAppDelegateorNSApplication/UIApplication(for Apple platforms). Firebase Messaging (FCM) support is also under consideration.tauri: Handle new eventsPushRegistrationeventPushRegistrationFailedeventtao: Hooks intoUIApplication/NSApplicationtauri-plugin-push-notifications:await pushToken(...)plugins-workspacetauri-docspush-notificationsplugin documentation tauri-docs#2997PR Tree
This PR is accompanied by a plugin,
tauri-plugin-push-notifications, and a PR totao:push-notificationsplugin documentation tauri-docs#2997Known Issues
Warning
This functionality is experimental and is gated behind the
push-notificationsfeature for now.How it works
(1)
taoandtauriforward two new events:PushRegistration(PushToken)andPushRegistrationFailed(Error).(2) a new plugin,
tauri-plugin-push-notifications, listens for these events, holds the token or error, and exposes those values to guest code when requested.sequenceDiagram tao->>+OS: Setup app delegate OS->>+tao: applicationDidFinishLaunching tao->>+OS: registerForRemoteNotifications() OS->>+tao: didFinishRegisteringWithToken() tao->>+tauri: PushRegistration(PushToken) Event tauri->>+Plugin: Forward event Plugin->>+Plugin: Retain token in-memory tauri->>+App: Launch app App<<->>+Plugin: await pushToken()